Fix clean area v2 for HA#1507
Open
MarkusMWolff wants to merge 7 commits into
Open
Conversation
Adjust CleanAreaV2 to handle SPOT_AREA mode correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1507 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 153 153
Lines 6010 6013 +3
Branches 350 351 +1
=======================================
+ Hits 5699 5702 +3
Misses 249 249
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edenhaus
requested changes
Apr 1, 2026
| "type": mode.value, | ||
| "value": ",".join(str(i) for i in area), | ||
| } | ||
| if mode == CleanMode.SPOT_AREA: |
Member
There was a problem hiding this comment.
This will break many bots as for example my bot does not support freeclean.
We don't can change it like this... We need to extend the capabilities so this command is aware of the model and changes only for the models which need it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the clean area method available to Home Assistant for newer models using the V2 API.
Related to: home-assistant/core#165933